Missing version tags for docker-outside-of-docker

[rubensa]

Looks like last docker-outside-of-docker tag is feature_docker-outside-of-docker_1.3.2 (for version 1.3.2 from January).

Following versions (1.4.0, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.5.0) have not been tagged (see: https://github.com/devcontainers/features/commits/main/src/docker-outside-of-docker/devcontainer-feature.json).

Could you, please, add tags for the missing releases (so it is easy to get the code at specific version)? (and keep that tagging for future releases, like this).

[rubensa]

Looks like the same is happening for other features.

For example, last tag for node is feature_node_1.4.0 where the last code is 1.6.0.

[rubensa]

Looks like the tagging support was introduced in devcontainers/action version v1.3.0 but it's not working since last February so might me a bug silently introduced in latest version v1.4.2 released on Feb 16 ?

[rubensa]

Looks like automatic tagging is failing. For example, in last release execution, in the log there is the message:

Adding repo tag 'feature_desktop-lite_1.2.5'...
Warning: Failed to automatically add repo tag, manually tag with:   'git tag feature_desktop-lite_1.2.5 b0667c5589bfe1b382c49392c58fe4c9433f1fde'

[rubensa]

The message comes from here.

[rubensa]

As far as I can see, the culprit might be the replacement from jsonc-parser to json5 that might be, somehow, making the call with octokit to create the tag, to fail.

[bryanlittlefield]

Seeing the same issues on our end also. This has become more critical as our team is navigating around Issue #1017

[bamurtaugh]

Thanks all for flagging. @joshspicer would you mind taking a look, given your expertise in devcontainers/action?

[joshspicer]

As far as I can see, the culprit might be the replacement from jsonc-parser to json5 that might be, somehow, making the call with octokit to create the tag, to fail.

Hm, not clear to me why we moved away from jsonc-parser (which is used extensively within dev container tooling and is definitely tolerant of comments, per that PR's goal).

Looks like there was just once instance of using the built-in JSON parser https://github.com/devcontainers/action/issues/210#issuecomment-1945199002, which I imagine should've been the only change in that PR🤔

[joshspicer]

I forked the latest build of the extension and ran it against a demo repo - tagging worked fine. I suspect this is a configuration issue on this repo

[joshspicer]

Comparing the two runs, it appears to be a permissions issue with the GITHUB_TOKEN:

[rubensa]

Just checked and seems tags are being generated again.

@bamurtaugh Should it be possible to add the "old" missing tags?

[bamurtaugh]

Thanks for the question @rubensa - @joshspicer it'd be awesome to get your insights!

[joshspicer]

We don't have any automated tooling for this and as it's one-off it is probably faster to update the tags manually. Are you (and other folks reading this) interested primarily in the tags for docker-outside-of-docker?