devcontainers.github.io icon indicating copy to clipboard operation
devcontainers.github.io copied to clipboard

docs: add devcontainer-features and devcontainer-templates from irfansofyana

Open irfansofyana opened this issue 1 year ago • 4 comments

What type of PR is this?

  • [x] Add a new dev container collection
  • [ ] Update to an existing dev container collection
  • [ ] Documentation/spec update
  • [ ] Other containers.dev site update (UX, layout, etc)

Related Issues

  • Related Issue #
  • Closes #

Description

Hi folks, I'm adding my devcontainer-features: https://github.com/irfansofyana/devcontainer-features currently it contains kafkacat/kcat CLI that I cannot found in other features hence I created it.

I also add https://github.com/irfansofyana/devcontainer-templates to add a few templates, currently it contains go-template (a template for go developer)

Collection checklist

If your PR contributes a new collection, please utilize this checklist:

  • [x] Collection name
  • [x] Maintainer name
  • [x] Maintainer contact link (i.e. link to a GitHub repo, email)
  • [x] Repository URL
  • [x] OCI Reference
  • [x] I acknowledge that this collection provides new functionality, distinct from the existing collections part of this index.

irfansofyana avatar Jan 02 '25 06:01 irfansofyana

Hi @irfansofyana ,

Thank you for the PR. The feature one looks fine. But the template one (https://github.com/irfansofyana/devcontainers-templates) seems like a private repo. I am unable to see it. Would you kindly check once.

With Regards, Kaniska

Kaniska244 avatar Feb 20 '25 13:02 Kaniska244

Hi @irfansofyana ,

Thank you for the PR. The feature one looks fine. But the template one (https://github.com/irfansofyana/devcontainers-templates) seems like a private repo. I am unable to see it. Would you kindly check once.

With Regards, Kaniska

oopss my bad it's a typo, it should be https://github.com/irfansofyana/devcontainer-templates, will fix it

irfansofyana avatar Feb 20 '25 14:02 irfansofyana

please review it again @Kaniska244

irfansofyana avatar Feb 20 '25 14:02 irfansofyana

Change approved. This can be merged.

Kaniska244 avatar Feb 24 '25 14:02 Kaniska244

Please re-review it again @eljog

irfansofyana avatar Mar 07 '25 14:03 irfansofyana

@irfansofyana changes approved! Sorry, but can you address the merge conflicts again before we merge this?

ddoyle2017 avatar Apr 09 '25 14:04 ddoyle2017