devcontainers.github.io icon indicating copy to clipboard operation
devcontainers.github.io copied to clipboard

Add The Nefarious Developer devcontainers to index

Open NickChecan opened this issue 1 year ago • 3 comments

What type of PR is this?

  • [X] Add a new dev container collection
  • [ ] Update to an existing dev container collection
  • [ ] Documentation/spec update
  • [ ] Other containers.dev site update (UX, layout, etc)

Related Issues

  • Related Issue #
  • Closes #

Description

Add devcontainer templates from the org The Nefarious Developer to the index.

Collection checklist

If your PR contributes a new collection, please utilize this checklist:

  • [X] Collection name
  • [X] Maintainer name
  • [X] Maintainer contact link (i.e. link to a GitHub repo, email)
  • [X] Repository URL
  • [X] OCI Reference
  • [X] I acknowledge that this collection provides new functionality, distinct from the existing collections part of this index.

NickChecan avatar Oct 19 '24 03:10 NickChecan

Hi @NickChecan ,

Thank you for the PR. The ORAS spec requires the ociReference to be in lower case. Would you kindly update the same. The supporting tools do help convert the case, however, its better to sync as much as possible.

With Regards, Kaniska

Kaniska244 avatar Feb 21 '25 16:02 Kaniska244

Hi @NickChecan ,

Thank you for the PR. The ORAS spec requires the ociReference to be in lower case. Would you kindly update the same. The supporting tools do help convert the case, however, its better to sync as much as possible.

With Regards, Kaniska

No problem at all @Kaniska244 . Thanks for the analysis and feedback. I made the change as requested. Let me know if anything else is needed from my side.

NickChecan avatar Feb 21 '25 19:02 NickChecan

Change approved. This can be merged.

Kaniska244 avatar Feb 24 '25 14:02 Kaniska244

@Kaniska244 and @eljog conflicts were resolved. Can you please approve so it can be merged? Thanks in advance.

NickChecan avatar Feb 26 '25 03:02 NickChecan