chef-apache-hardening icon indicating copy to clipboard operation
chef-apache-hardening copied to clipboard
verified publisher icon dev-sec

Cookstyle Bot Auto Corrections with Cookstyle 7.31.1

Open cookstyle[bot] opened this issue 4 years ago • 0 comments

This change is automatically generated by the Cookstyle Bot using the latest version of Cookstyle (7.31.1). Adopting changes suggested by Cookstyle improves cookbook readability, avoids common coding mistakes, and eases upgrades to newer versions of the Chef Infra Client.

Style/Encoding

  • /Berksfile:1: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8)
  • /Gemfile:1: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8)
  • /Guardfile:1: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8)
  • /Rakefile:2: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8)
  • /attributes/default.rb:1: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8)
  • /attributes/hardening.rb:1: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8)
  • /recipes/default.rb:1: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8)
  • /recipes/hardening.rb:1: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8)
  • /spec/spec_helper.rb:1: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8)
  • /spec/unit/recipes/default_spec.rb:1: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8)
  • /spec/unit/recipes/hardening_spec.rb:1: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8)

Chef/Modernize/LegacyBerksfileSource

  • /Berksfile:3: Do not use legacy Berksfile community sources. Use Chef Supermarket instead. (https://docs.chef.io/workstation/cookstyle/chef_modernize_legacyberksfilesource)

Style/RegexpLiteral

  • /Guardfile:7: Use %r around regular expression. (https://rubystyle.guide#percent-r)
  • /Guardfile:11: Use %r around regular expression. (https://rubystyle.guide#percent-r)
  • /Guardfile:12: Use %r around regular expression. (https://rubystyle.guide#percent-r)
  • /Guardfile:13: Use %r around regular expression. (https://rubystyle.guide#percent-r)
  • /Guardfile:14: Use %r around regular expression. (https://rubystyle.guide#percent-r)
  • /Guardfile:19: Use %r around regular expression. (https://rubystyle.guide#percent-r)
  • /Guardfile:20: Use %r around regular expression. (https://rubystyle.guide#percent-r)
  • /Guardfile:25: Use %r around regular expression. (https://rubystyle.guide#percent-r)
  • /Guardfile:26: Use %r around regular expression. (https://rubystyle.guide#percent-r)
  • /Guardfile:27: Use %r around regular expression. (https://rubystyle.guide#percent-r)
  • /Guardfile:28: Use %r around regular expression. (https://rubystyle.guide#percent-r)
  • /Guardfile:29: Use %r around regular expression. (https://rubystyle.guide#percent-r)
  • /Guardfile:30: Use %r around regular expression. (https://rubystyle.guide#percent-r)
  • /Guardfile:31: Use %r around regular expression. (https://rubystyle.guide#percent-r)

Layout/ExtraSpacing

  • /Guardfile:20: Unnecessary spacing detected.
  • /Guardfile:21: Unnecessary spacing detected.

Chef/Style/CommentFormat

  • /attributes/default.rb:3: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  • /attributes/default.rb:6: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  • /attributes/default.rb:7: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  • /attributes/hardening.rb:3: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  • /attributes/hardening.rb:6: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  • /attributes/hardening.rb:7: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  • /recipes/default.rb:3: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  • /recipes/default.rb:6: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  • /recipes/default.rb:7: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  • /recipes/hardening.rb:3: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  • /recipes/hardening.rb:6: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  • /recipes/hardening.rb:7: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)

Chef/Sharing/InvalidLicenseString

  • /metadata.rb:4: Cookbook metadata.rb does not use a SPDX compliant license string or "all rights reserved". See https://spdx.org/licenses/ for a complete list of license identifiers. (https://docs.chef.io/workstation/cookstyle/chef_sharing_invalidlicensestring)

Chef/RedundantCode/LongDescriptionMetadata

  • /metadata.rb:6: The long_description metadata.rb method is not used and is unnecessary in cookbooks. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_longdescriptionmetadata)

Chef/RedundantCode/RecipeMetadata

  • /metadata.rb:11: The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the cookbook's README.md file instead. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_recipemetadata)
  • /metadata.rb:12: The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the cookbook's README.md file instead. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_recipemetadata)

Chef/Style/IncludeRecipeWithParentheses

  • /recipes/default.rb:22: There is no need to wrap the recipe in parentheses when using the include_recipe helper (https://docs.chef.io/workstation/cookstyle/#includerecipewithparentheses)

Layout/TrailingEmptyLines

  • /spec/spec_helper.rb:7: 1 trailing blank lines detected. (https://rubystyle.guide#newline-eof)

Chef/Deprecations/ChefSpecCoverageReport

  • /spec/spec_helper.rb:9: Don't use the deprecated ChefSpec coverage report functionality in your specs. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_chefspeccoveragereport)

Layout/EmptyLinesAroundBlockBody

  • /spec/unit/recipes/default_spec.rb:6: Extra empty line detected at block body beginning. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/default_spec.rb:20: Extra empty line detected at block body end. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:6: Extra empty line detected at block body beginning. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:18: Extra empty line detected at block body beginning. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:24: Extra empty line detected at block body end. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:30: Extra empty line detected at block body beginning. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:34: Extra empty line detected at block body end. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:38: Extra empty line detected at block body beginning. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:40: Extra empty line detected at block body beginning. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:44: Extra empty line detected at block body end. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:46: Extra empty line detected at block body end. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:50: Extra empty line detected at block body beginning. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:52: Extra empty line detected at block body beginning. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:58: Extra empty line detected at block body end. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:60: Extra empty line detected at block body end. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:64: Extra empty line detected at block body beginning. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:67: Extra empty line detected at block body end. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:71: Extra empty line detected at block body beginning. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:74: Extra empty line detected at block body end. (https://rubystyle.guide#empty-lines-around-bodies)
  • /spec/unit/recipes/hardening_spec.rb:76: Extra empty line detected at block body end. (https://rubystyle.guide#empty-lines-around-bodies)

Signed-off-by: Cookstyle [email protected]

cookstyle[bot] avatar Jan 26 '22 21:01 cookstyle[bot]