TypeChain icon indicating copy to clipboard operation
TypeChain copied to clipboard

Set signerOrProvider optional

Open Rubilmax opened this issue 3 years ago • 5 comments

Hi,

Here's the Contract constructor signature from ethers v5:

constructor(addressOrName: string, contractInterface: ContractInterface, signerOrProvider?: Signer | Provider)

I was thus wondering why TypeChain forces signerOrProvider to be defined, whereas ethers does not (and we've got a use-case where we don't want to define a signer nor a provider)

So here's a quick PR to fix this :)

Rubilmax avatar Sep 07 '22 09:09 Rubilmax

⚠️ No Changeset found

Latest commit: c169fd24cb1db85fb247be2210f2a312187bc789

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 07 '22 09:09 changeset-bot[bot]

Thanks for this! Much needed! @krzkaczor

mihaic195 avatar Sep 12 '22 11:09 mihaic195

+1 to this

iainnash avatar Sep 27 '22 23:09 iainnash

This has been open for almost 2 months and the problem is still there. @krzkaczor can we get this merged, please?

mihaic195 avatar Oct 27 '22 11:10 mihaic195

Up

Rubilmax avatar Jun 05 '23 08:06 Rubilmax