dugite-native
dugite-native copied to clipboard
desktop
Can't commit with git-secrets
Description
Git-secrets fails to run (I think because it can't find git-sh-setup). Specifically, the error raised points to line 46, and the built-in git has a weird exec-path:
$ /Applications/GitHub\ Desktop.app/Contents/Resources/app/git/bin/git --exec-path
//libexec/git-core
Version
- GitHub Desktop: 1.6.0
- Operating system: macOS 10.13.6 (17G4015)
Steps to Reproduce
Set up git-secrets in a repo, then try to commit any file.
Expected Behavior
Commit succeeds.
Actual Behavior
Commit fails with error No such file or directory.
Additional Information
Logs
2019-01-18T22:18:28.902Z - error: [ui] `git commit -F -` exited with an unexpected code: 1.
/usr/local/bin/git-secrets
/usr/local/bin/git-secrets: line 46: /Applications/GitHub: No such file or directory
@zarsky-broad thanks for the report!
This is the same root cause as https://github.com/desktop/dugite-native/issues/164 and needs to be addressed in the embedded Git. I'm going to move this over the related project so we can track it there.
