python-graphiteudp icon indicating copy to clipboard operation
python-graphiteudp copied to clipboard

Alter behavior of debug flag

Open pkmurph opened this issue 10 years ago • 1 comments

Always log the intended message (use Python logging mechanism to control whether the log message is emitted) Use the debug flag strictly to control whether or not the UDP message is sent.


I found it a big confusing that the debug flag affected the ultimate functionality, I guess it's being used as a "test" flag in actuality. I think it's helpful to be able to debug log the message even when it's actually being sent, and if I want to squelch it, I can tell Python logging to do that.

pkmurph avatar Jun 25 '15 19:06 pkmurph

Seems reasonable. I'm worried about the inefficiency in doing the string substitution operation for a log message that will almost always be ignored. Can you replace % with , so that the string substitution is delayed until the logging module wants to do it, please?

The other thing I'm concerned about is generating noise by default. Do you think it should be quiet by default?

derpston avatar Jul 01 '15 11:07 derpston