How to remove manisfest from log ?
The file https://deployer.org/manifest.json is downloaded and the content is shown in logs, 860 lines...
I don't think it's possible to hide content currently: https://github.com/deployphp/action/blob/v1.0.23/index.js#L89.
In case of a curl error, keeping the log is valuable, I think.
What would be the right approach to fix the problem ?
Idea:
- Save manifest.json in file with curl option --output
- If no error parse it
- In case of error show the content file
Upvote & Fund
- We're using Polar.sh so you can upvote and help fund this issue.
- We receive the funding once the issue is completed & confirmed by you.
- Thank you in advance for helping prioritize & fund our backlog.
I agree: It would be good to remove it :)
I use this in GitHub Actions:
steps:
- name: Checkout
uses: actions/checkout@v6
- name: Deploy
uses: deployphp/action@v1
with:
private-key: ${{ secrets.PRIVATE_KEY }}
dep: deploy -vv
deployer-version: "7.5.12"
So I provide a specific version.
Can the action just try to download that version, and skip the request to manifest.json ? Would you accept a PR that skip manifest.json if deployer-version is defined? Then if someone use an invalid version, it would still display an error because curl will fail.
Update: I just saw a PR that would hide the JSON file:
- GH-89
So there’s no need to open another PR about this subject.