dependabot-core icon indicating copy to clipboard operation
dependabot-core copied to clipboard

Positional Dependency does not update with Gradle KTS

Open NyCodeGHG opened this issue 4 years ago • 4 comments

Package ecosystem

Gradle Manifest location and content prior to update https://github.com/NyCodeGHG/dependabot-test/blob/5f9f088aef544e347aabf946d02195c6e0cb79b5/build.gradle.kts dependabot.yml content

https://github.com/NyCodeGHG/dependabot-test/blob/5f9f088aef544e347aabf946d02195c6e0cb79b5/.github/dependabot.yml Updated dependency

implementation("org.slf4j", "slf4j-api", "1.7.30")
// Should update to
implementation("org.slf4j", "slf4j-api", "1.7.31")

What you expected to see, versus what you actually saw I expected the dependency to get updated. Dependabot didn't recognized the dependency and it wasn't present in the logs.

Images of the diff or a link to the PR, issue or logs https://hastebin.com/dasofisise.yaml 🕹 Bonus points: Smallest manifest that reproduces the issue

build.gradle.kts:

plugins {
    kotlin("jvm") version "1.5.10" // or java plugin
}

repositories {
    mavenCentral()
}

dependencies {
    implementation("org.slf4j", "slf4j-api", "1.7.30")
}

NyCodeGHG avatar Jun 21 '21 13:06 NyCodeGHG

Related to #1164 as tooling api would cover this

DRSchlaubi avatar Jun 21 '21 18:06 DRSchlaubi

I agree with _DRSchlaubi, the tooling API is the way to actually fix this. For detecting the dependency at least... I'm less sure that the tooling API will making updating "1.7.30" to "1.7.31" easier, but I'd love to learn if it is.

For now, is expressing dependencies in the format Dependabot can parse an acceptable workaround?

thepwagner avatar Jun 25 '21 17:06 thepwagner

if it is not possible to change that, that would be ok, but I find the syntax that I use now much more readable

NyCodeGHG avatar Jun 25 '21 20:06 NyCodeGHG

👋 This issue has been marked as stale because it has been open for 2 years with no activity. You can comment on the issue to hold stalebot off for a while, or do nothing. If you do nothing, this issue will be closed eventually by the stalebot. Please see CONTRIBUTING.md for more policy details.

github-actions[bot] avatar Aug 25 '24 00:08 github-actions[bot]