Parvus icon indicating copy to clipboard operation
Parvus copied to clipboard

Use <dialog> element

Open medienbaecker opened this issue 1 year ago • 1 comments

I finally had the chance to test Parvus today, and I love it — finally an accessible lightbox!

What do you think about using the dialog element instead of a z-index of 1337? :) Also: automatic ARIA role, focus management, keyboard navigation — I think it would be a great fit.

medienbaecker avatar Jul 08 '24 17:07 medienbaecker

Moin @medienbaecker 👋,

the native dialog element has also been on my list for some time. I think it's best to implement it with the next major release (3.0.0), which I plan to start next weekend.

deoostfrees avatar Jul 09 '24 12:07 deoostfrees

Version 3.0.0 is now available as a beta and will be released shortly after some intensive testing, thus closing this issue.

deoostfrees avatar Mar 11 '25 11:03 deoostfrees

Can confirm the dialog element is working fine in 3.0.0-beta!

sciloqi avatar Mar 11 '25 11:03 sciloqi

Hi @sciloqi, I just read your other comment and was about to try to reproduce it. Thank you for letting me know.

deoostfrees avatar Mar 11 '25 11:03 deoostfrees

Hi @sciloqi, I just read your other comment and was about to try to reproduce it. Thank you for letting me know.

Thanks for coming back to this, but all is ok. i accidentally switched to an old version when testing the beta, but both 3.0.0-alpha and 3.0.0-beta work fine, even if you open a lightbox from another dialog element. So, everything is perfect, thank you very much! 👍

sciloqi avatar Mar 11 '25 12:03 sciloqi

Great job, it's working for me, too 👍

medienbaecker avatar Mar 13 '25 08:03 medienbaecker