setup-deno icon indicating copy to clipboard operation
setup-deno copied to clipboard

Default to `v1.x`?

Open dsherret opened this issue 3 years ago • 4 comments

Instead of writing:

- uses: denoland/setup-deno@v1
  with:
    deno-version: v1.x

It would be nice to write:

- uses: denoland/setup-deno@v1

Then when deno v2 is released we can bump the version of this action:

- uses: denoland/setup-deno@v2

The one risk for this is if we would want to make any breaking changes to the action, but I feel we could just do that when a new major deno version release occurs.

~~This would not be a breaking change because not providing a deno-version currently errors.~~

dsherret avatar Feb 19 '22 23:02 dsherret

It looks like we do have a default, but I didn't test that it works. https://github.com/denoland/setup-deno/blob/d4873ceeec10de6275fecd1f94b6985369d40231/action.yml#L10

satyarohith avatar Mar 04 '22 22:03 satyarohith

@satyarohith oh, I didn't realize a default was able to be set there. Do you think this would be a good versioning strategy going forward? Maybe we could add it to the readme?

dsherret avatar Mar 05 '22 03:03 dsherret

Do you think this would be a good versioning strategy going forward? Maybe we could add it to the readme?

I'm in favor. In addition to mentioning it in the readme, it would be nice to have a test that exercises this condition in test.yml.

satyarohith avatar Mar 06 '22 06:03 satyarohith

just to add my 2¢, I'd expect the default to be the latest stable version of deno (of any major) and the version of the action to not effect the version of deno. But perhaps I'm too experienced with actions…

mxcl avatar Feb 06 '23 15:02 mxcl