PyTorchNLPBook icon indicating copy to clipboard operation
PyTorchNLPBook copied to clipboard

Errors in Yelp notebook

Open isoboroff opened this issue 6 years ago • 1 comments

In the Chapter 3 notebook on preprocessing the Yelp data (LITE), there is duplicated code in blocks 4, 9, and 10. I don't the book in front of me right now, so maybe there's a reason why you do everything two or three times, but just reading the notebook I don't see why. If I'm wrong some comments would be good here.

isoboroff avatar Mar 27 '19 12:03 isoboroff

Specifically, in block 10, the code

         train_bar.n = 0
         val_bar.n = 0
         epoch_bar.update()

seems to be duplicated which leads to the epoch bar incorrectly updating twice for each epoch.

aoifecahill avatar Mar 29 '19 17:03 aoifecahill