builder should also support password callback

Open smothiki opened this issue 9 years ago • 2 comments

Right now we are just using password callback in tests, it would be nice to support password call back , keeping in mind stand alone builder work.

May 11 '16 22:05 smothiki

I don't think this is something we want to allow. In a multi-tenant environment everyone should not have access to the git user's password, as there is no way we can authenticate who is pushing the build in the controller.

Keeping this open for discussion but I believe we should only allow keys. Much easier to allow/reject than changing a global password on a public PaaS.

Oct 31 '16 20:10 bacongobbler

This issue was moved to teamhephy/builder#28

Mar 21 '18 13:03 Cryptophobia