SpecHLA icon indicating copy to clipboard operation
SpecHLA copied to clipboard

Feature request

Open Redmar-van-den-Berg opened this issue 2 years ago • 7 comments

Would it be possible to add an option to specify the HLA database folder to use, rather than using the hardcoded 'db' option?

Redmar-van-den-Berg avatar Mar 21 '24 15:03 Redmar-van-den-Berg

Hi, we can certainly add an option. The database (db) is a customized database created by SpecHLA. Could you please elaborate on the utility of this option or specify the scenarios where it would be applicable? Thanks.

wshuai294 avatar Mar 22 '24 04:03 wshuai294

When I'm creating a pipeline, I like to have a small test dataset (of both samples and reference files) that I can quickly run to test that the pipeline is working (ideally, it should run in a few seconds). So my use case for this request would be to shrink the database down to only include the alleles that I know are present in my test samples, and then use the small database to test the pipeline I'm working on.

Redmar-van-den-Berg avatar Mar 22 '24 12:03 Redmar-van-den-Berg

Hi, the database contains complex information, which makes it difficult to shrink. We do not recommend modifying it. However, even with the original database, SpecHLA can process the provided example data (exon) within a few minutes. If your test data consists of reads from a single gene, it will be even faster. Therefore, we believe the test time should be acceptable with the original database. Thanks.

wshuai294 avatar Mar 25 '24 04:03 wshuai294

I understand, but I still think it would be nice to not have things like the database location or the conda environment hard coded. Hard coded values make it much more difficult to use the tool and integrate it in other systems, for example conda or biocontainers.

Redmar-van-den-Berg avatar Mar 28 '24 09:03 Redmar-van-den-Berg

Agreed, we will add this option as suggested soon. Thanks.

wshuai294 avatar Mar 28 '24 14:03 wshuai294

@wshuai294 I'm happy to help out with this, would you like me to create a pull request for this functionality?

Redmar-van-den-Berg avatar Apr 24 '24 10:04 Redmar-van-den-Berg

Hi, sorry for the delay. It will be greatly appreciated if you create a pull request for this functionality! Thanks so much.

wshuai294 avatar Apr 24 '24 11:04 wshuai294