dpgen icon indicating copy to clipboard operation
dpgen copied to clipboard

Add parameter 'srtab_file_path' so that one can use DP-ZBL potential successfully

Open Chengqian-Zhang opened this issue 3 years ago • 7 comments

Signed-off-by: Chenqqian Zhang [email protected] Now there is a problem, if someone wants to use zbl potential, the energy table will not be copied into the task folder with input.json, I added a new parameter "srtab_file_path" , the user needs to write the path of the energy table, when generating the training task, this file will be copied into the task folder.

Chengqian-Zhang avatar Aug 25 '22 10:08 Chengqian-Zhang

Codecov Report

Base: 39.48% // Head: 39.49% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (fb7e476) compared to base (572fbfd). Patch coverage: 55.55% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel     #918   +/-   ##
=======================================
  Coverage   39.48%   39.49%           
=======================================
  Files          99       99           
  Lines       17989    17998    +9     
=======================================
+ Hits         7103     7108    +5     
- Misses      10886    10890    +4     
Impacted Files Coverage Δ
dpgen/generator/run.py 65.04% <50.00%> (-0.05%) :arrow_down:
dpgen/generator/arginfo.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Aug 25 '22 10:08 codecov-commenter

please edit the title of the PR to make it informative.

wanghan-iapcm avatar Aug 26 '22 02:08 wanghan-iapcm

I have completed that.

Chengqian-Zhang avatar Aug 26 '22 03:08 Chengqian-Zhang

Please add the parameter to arginfo.py. I have added it to 'arginfo.py'. Please check.

Chengqian-Zhang avatar Aug 26 '22 04:08 Chengqian-Zhang

the conflict should be resolved.

wanghan-iapcm avatar Aug 27 '22 04:08 wanghan-iapcm

  1. There're Python syntax errors in your new commits. You should at least run a demo if you're not familiar with your code.

Screen Shot 2022-08-28 at 11 21 49 PM

  1. You should solve the conflicts whenever you want to create the pull request

@Chengqian-Zhang

AnguseZhang avatar Aug 28 '22 15:08 AnguseZhang

I have modified the code and resolved the conflict . Please check.

Chengqian-Zhang avatar Sep 01 '22 04:09 Chengqian-Zhang

I have modified the code according to your suggestions, please review again.

Chengqian-Zhang avatar Dec 03 '22 08:12 Chengqian-Zhang