abacus-develop icon indicating copy to clipboard operation
abacus-develop copied to clipboard

Refactor: SphericalBesselTransformer cleanup

Open jinzx10 opened this issue 1 year ago • 0 comments

Reminder

  • [ ] Have you linked an issue with this pull request?
  • [ ] Have you added adequate unit tests and/or case tests for your pull request?
  • [ ] Have you noticed possible changes of behavior below or in the linked issue?
  • [ ] Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

This PR is related to #4079

What's changed?

  • With the help of cubic spline, the calculation of the derivative of spherical Bessel transforms are no longer required. The relevant part of the code is therefore removed for clarity, and the whole class is slimmed down.
  • Various raw pointers are replaced by std::vector
  • The interface is designed for easier use by other classes in module_nao

Any changes of core modules? (ignore if not applicable)

No

jinzx10 avatar May 11 '24 07:05 jinzx10