launchpad icon indicating copy to clipboard operation
launchpad copied to clipboard

Launchpad Release

Open ethanluoyc opened this issue 2 years ago • 7 comments

Hi Launchpad Team,

Thanks for trying to help us with the https://github.com/deepmind/launchpad/issues/32, however, I don't think we have a release for the new TF version. Both the nightly and stable versions?

I am currently using a wheel built from a source as mentioned in https://github.com/deepmind/launchpad/issues/30#issuecomment-1597262369. There are some additional fixes that seem to be required to work with TF 2.12.0. I am happy to create a PR if that is preferred (but maybe it's easier to update from internal). There seem to be some upgrades needed in terms of how to handle absl Status and tsl Status otherwise things are straightforward.

The update is quite useful as it is currently blocking using JAX agents in dm-acme at HEAD. dm-acme@HEAD now uses jax>0.4.3 which is incompatible with the TF/TFP version used in Acme.

@ddmbr what do you think?

ethanluoyc avatar Jul 06 '23 22:07 ethanluoyc

Hi! I'll try to make a release soon. Which version of TF and Reverb do you need?

ddmbr avatar Jul 10 '23 10:07 ddmbr

Thank you! I think maybe targeting TF 2.12.0 would be good (this is the version of TF that is used by the latest reverb update).

ethanluoyc avatar Jul 10 '23 11:07 ethanluoyc

Yeah tensorflow==2.12 or tensorflow==2.13 wheel would be much appreciated. If possible, for python==3.10 🙂

hartikainen avatar Jul 11 '23 16:07 hartikainen

reverb just released v0.12.0 which supports tensorflow==2.13. If the latest launchpad release is still in progress, it would be really neat to get it published with tensorflow==2.13.

hartikainen avatar Jul 20 '23 17:07 hartikainen

Ran into issues, still trying...

ddmbr avatar Jul 20 '23 20:07 ddmbr

Would you like to take a look at https://github.com/ethanluoyc/launchpad/tree/v0.5.2rc0+1 ? This is a working build for TF 2.12. I can create PR if that helps with importing the code for doing things internally.

ethanluoyc avatar Jul 20 '23 20:07 ethanluoyc

Thank you! I'll try your fix later

ddmbr avatar Jul 20 '23 20:07 ddmbr