oapi-codegen icon indicating copy to clipboard operation
oapi-codegen copied to clipboard

fix: typo unmarshalling

Open manuelarte opened this issue 4 months ago • 11 comments

I found some typos:

  • unmarshaling -> unmarshalling.
  • specificiation -> specification

manuelarte avatar Aug 29 '25 13:08 manuelarte

Kusari Inspector

Kusari Analysis Results:

Proceed with these changes
✅ No Flagged Issues Detected All values appear to be within acceptable risk parameters.

No pinned version dependency changes, code issues or exposed secrets detected!

[!NOTE] View full detailed analysis result for more information on the output and the checks that were run.


@kusari-inspector rerun - Trigger a re-analysis of this PR @kusari-inspector feedback [your message] - Send feedback to our AI and team See Kusari's documentation for setup and configuration. Commit: 89a67a50d2f9a8986a9602a4b1c58cce2bf25bd5, performed at: 2025-09-27T19:11:14Z

Found this helpful? Give it a 👍 or 👎 reaction!

kusari-inspector[bot] avatar Aug 29 '25 13:08 kusari-inspector[bot]

Kusari PR Analysis rerun based on - 5af7c1002465ce54b30a4be96096bce851e48005 performed at: 2025-08-29T13:39:10Z - link to updated analysis

kusari-inspector[bot] avatar Aug 29 '25 13:08 kusari-inspector[bot]

Wow. Good catch 👍

chaseisabelle avatar Aug 30 '25 23:08 chaseisabelle

Any comments?

manuelarte avatar Sep 06 '25 06:09 manuelarte

Kusari PR Analysis rerun based on - 970c583bd514c09e4e3000a659ccf432a1aaab0f performed at: 2025-09-13T19:18:26Z - link to updated analysis

kusari-inspector[bot] avatar Sep 13 '25 19:09 kusari-inspector[bot]

Kusari PR Analysis rerun based on - 2ffe9cb9a22e9f6d37d6a378f96377cee49d06e3 performed at: 2025-09-24T19:14:50Z - link to updated analysis

kusari-inspector[bot] avatar Sep 24 '25 19:09 kusari-inspector[bot]

Kusari PR Analysis rerun based on - 89a67a50d2f9a8986a9602a4b1c58cce2bf25bd5 performed at: 2025-09-27T19:11:34Z - link to updated analysis

kusari-inspector[bot] avatar Sep 27 '25 19:09 kusari-inspector[bot]

Hi,

I wanted to follow up on this PR which has been open for about a month. I've noticed there's been recent activity in the project with other PRs being merged, so I'm wondering what the next steps might be for this one.

I am happy to make any necessary changes or provide additional context if that would help. If this isn't a priority right now or doesn't fit with the project's direction, I'd appreciate knowing that too—I'd rather have clear feedback than leave it open indefinitely.

Thanks!

manuelarte avatar Sep 27 '25 19:09 manuelarte

Hi,

I wanted to follow up on this PR which has been open for about a month. I've noticed there's been recent activity in the project with other PRs being merged, so I'm wondering what the next steps might be for this one.

I am happy to make any necessary changes or provide additional context if that would help. If this isn't a priority right now or doesn't fit with the project's direction, I'd appreciate knowing that too—I'd rather have clear feedback than leave it open indefinitely.

Thanks!

This project is maintained by very busy folks who are probably going to want to pour through the changes manually, especially with the rise of AI attackings, so it's going to take some time. I'm not sure of any way to expedite the process; however, if you can think of one, please let me/us know :)

Personal plug: https://github.com/oapi-codegen/oapi-codegen/pull/2070 wink+nudge

chaseisabelle avatar Sep 28 '25 04:09 chaseisabelle

Hi, I wanted to follow up on this PR which has been open for about a month. I've noticed there's been recent activity in the project with other PRs being merged, so I'm wondering what the next steps might be for this one. I am happy to make any necessary changes or provide additional context if that would help. If this isn't a priority right now or doesn't fit with the project's direction, I'd appreciate knowing that too—I'd rather have clear feedback than leave it open indefinitely. Thanks!

This project is maintained by very busy folks who are probably going to want to pour through the changes manually, especially with the rise of AI attackings, so it's going to take some time. I'm not sure of any way to expedite the process; however, if you can think of one, please let me/us know :)

Personal plug: #2070 wink+nudge

Hi @chaseisabelle!

Thanks for your answer. I completely understand that maintainers are busy.

My main goal is just to clarify the status. At this point, I'd just like to know if:

  • This PR is still in the queue for a future review, or
  • It has been reviewed/checked and decided against merging.

If it's the latter, I'm totally fine with that—I'd just prefer to know so I can close the PR and don't need to invest time in keeping the branch updated.

Thanks again for your time!

manuelarte avatar Sep 28 '25 08:09 manuelarte

Thanks for the contribution!

To clarify:

My main goal is just to clarify the status. At this point, I'd just like to know if:

  • This PR is still in the queue for a future review, or
  • It has been reviewed/checked and decided against merging.

It's the former.

If it were the latter, I'd have dropped a comment / closed the PR accordingly

Please be patient - we've got quite a few other higher-priority PRs, and will get to this at some point!

I'd just prefer to know so I can close the PR and don't need to invest time in keeping the branch updated.

No worries about keeping it updated, I'll get it updated when I get round to it :)

Related: https://github.com/oapi-codegen/oapi-codegen/pull/1909#issuecomment-3344200422

jamietanna avatar Sep 28 '25 19:09 jamietanna