deepkit-framework icon indicating copy to clipboard operation
deepkit-framework copied to clipboard

HTTP: compression should not be enabled by default

Open alpharder opened this issue 1 year ago • 1 comments

The worst task JS could do is compression. It's usually better handled by ingress servers such as Nginx, Caddy or Traefik.

I would ditch compression from the framework completely or it should be at least disabled by default.

See FrameworkConfig,

    /**
     * The compression level to use when using the zlib module.
     * 0 means no compression, and 9 is the maximum compression.
     */
    compression: number = 6;

alpharder avatar Jul 06 '24 06:07 alpharder

it's fine, not everyone needs a reverse proxy and has low load, for these use-cases we keep it

marcj avatar Jul 06 '24 08:07 marcj