web-client-ui icon indicating copy to clipboard operation
web-client-ui copied to clipboard

Fix linting errors for importing from @adobe/react-spectrum

Open mattrunyon opened this issue 1 year ago • 0 comments

When completing #1908, we forgot to run the linter on all files locally since CI only lints changed files. As a result, there are some places that violate the rule and fail linting, but weren't caught because the files weren't changed.

I think we should expand the rule to allow @adobe/react-spectrum anywhere inside packages/components. It's unclear to me what components/src/spectrum actually is. We modify and re-export ComboBox for example, but then have SearchableComboBox in components/src. What makes the modified and re-exported ComboBox belong in the spectrum folder? I thought they should all be pure re-exports

mattrunyon avatar Aug 20 '24 17:08 mattrunyon