web-client-ui icon indicating copy to clipboard operation
web-client-ui copied to clipboard
verified publisher icon deephaven

Theme should switch between light/dark based on system setting

Open rbasralian opened this issue 1 year ago • 2 comments

It would be really convenient if the UI theme switched based on whether the system is in light vs. dark mode. Like GitHub does when "theme mode" is set to "Sync with System":

image

I would argue that this should be the default. (The themes corresponding with light mode and dark mode should still be configurable, but should default to our current "Default Light"/"Default Dark" themes.)

rbasralian avatar Apr 16 '24 14:04 rbasralian

Should be easy enough to detect: https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme https://medium.com/hypersphere-codes/detecting-system-theme-in-javascript-css-react-f6b961916d48

mofojed avatar Apr 16 '24 14:04 mofojed

I was hesitant to do that right off the bat until we had more soak time with the light theme to make sure we hadn't missed anything crucial.

dsmmcken avatar Apr 16 '24 14:04 dsmmcken