deepflow icon indicating copy to clipboard operation
deepflow copied to clipboard

[FR] FR-30: tempo data has no network span

Open shaohuading opened this issue 2 years ago • 3 comments

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

DeepFlow Component

Server

What you expected to happen

火焰图中包含应用span, 系统span和网络span,而通过tempo接口,只能查询到应用span和系统span, 网络span数据是缺失的。查看deepflow-app的源码,发现是有对网络span数据的处理的。 image image image

How to reproduce

No response

DeepFlow version

deepflow-server: v6.2.5 deepflow-app:latest

DeepFlow agent list

No response

Kubernetes CNI

No response

Operation-System/Kernel version

No response

Anything else

No response

Are you willing to submit a PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

shaohuading avatar Mar 27 '23 09:03 shaohuading

When adapting Tempo, in order to reduce the complexity of implementation, we did not support net span at the beginning. This feature will be completed in v6.3.

sharang avatar Apr 18 '23 01:04 sharang

Is the feature completed yet at present? thanks

duanshuaimin avatar Jul 29 '24 07:07 duanshuaimin

@duanshuaimin The net-span and sys-span currently share the same span ID, and there isn’t a good way to display them without modifying Tempo. We are still considering solutions and may need to recalculate the span IDs.

Additionally, we are considering another issue: in most cases, users only need to check the sys-span and app-span. If a network issue is suspected, they can directly search for the span ID in the request-log panel to identify which network hop is causing the problem. In other words, not displaying the net-span in Tempo might make the results simpler and more readable.

sharang avatar Aug 21 '24 10:08 sharang