d-voting icon indicating copy to clipboard operation
d-voting copied to clipboard

feat: dockerized deployment

Open PascalinDe opened this issue 1 year ago • 6 comments

includes all the relevant files for the new dockerized deployment, including a helper script to set up/tear down a development environment

PascalinDe avatar Apr 03 '24 13:04 PascalinDe

I'll have a look why the test is broken, it seems like there's some problem with the DELA version...

PascalinDe avatar May 02 '24 07:05 PascalinDe

I'll have a look why the test is broken, it seems like there's some problem with the DELA version...

Yes, it relies on the latest dela with the new protocol names.

ineiti avatar May 02 '24 11:05 ineiti

since the reason the test is failing is not related to this PR, I think it can be merged

@jbsv I'll let you hit the merge button

PascalinDe avatar May 03 '24 08:05 PascalinDe

since the reason the test is failing is not related to this PR, I think it can be merged

@jbsv I'll let you hit the merge button

Sorry, no, please don't merge. If you do, you put the dedis/d-voting repository in an unstable state. We first need to merge the dela-PR before this PR can be merged.

@edit: didn't see that this goes into c4dt-main, sorry. But before we can merge it into main, dela needs to be updated with our changes.

@jbsv hit merge, please!

ineiti avatar May 03 '24 12:05 ineiti

since the reason the test is failing is not related to this PR, I think it can be merged @jbsv I'll let you hit the merge button

Sorry, no, please don't merge. If you do, you put the dedis/d-voting repository in an unstable state. We first need to merge the dela-PR before this PR can be merged.

maybe I missed something, but how would this PR put the repository in an unstable state? it's only for a merge onto our branch (c4dt-main) and only contains some documentation, the code for the Docker images and a script - none of which are executed automatically (the Docker images are only build on the main branch by the CI)

also the CI for the tests is already broken on this branch

PascalinDe avatar May 03 '24 14:05 PascalinDe

@jbsv - just to make sure you saw the edit of my message above: please hit merge :)

ineiti avatar May 06 '24 08:05 ineiti