bonzo icon indicating copy to clipboard operation
bonzo copied to clipboard

Lighter syntax for `create()`?

Open aawwawa opened this issue 13 years ago • 4 comments

Discussed this with @rvagg in IRC briefly. Here's the alias I would propose:

bonzo.new = function(tagname) { 
    return bonzo.create('<'+ tagname +'>');
};

It could obviously be implemented more performantly as a direct interface to the DOM, but I think it would be a more intuitive API. The current name create() evokes the native DOM's document.create(), which accepts a tag name, not a tag. So intuitively I always want to write bonzo.create('div'), and not bonzo.create('<div>'). That was perhaps the most recurring hitch in my adjustment to the API, FWIW.

aawwawa avatar Sep 05 '12 02:09 aawwawa

Using new('div') would read better aloud, and make more intuitive sense as english. In my brief tests, having a member function of an object called new() does NOT conflict with the JS new keyword.

aawwawa avatar Sep 05 '12 02:09 aawwawa

im digging this. should we worry about new'ing multiple elements, at all? that might be dumb and complicating things that don't need to be. i'm all for this alias though.

connor avatar Nov 25 '12 08:11 connor

It's really just an alias for document.createElement(tagname), the overhead of bonzo.create() can be completely avoided for this case. But because it's just duplicating an existing function that's available across browsers then perhaps this is just fluff?

rvagg avatar Nov 25 '12 09:11 rvagg

We did this on Medium.com in an internal version of ender (just extending $).

$.createElement = function (tagName) {
  return $(document.createElement(tagName))
}

there were cases in the Editor where i'd need to create an Ender element out of a tag name. and it was more of a hassle to do this...

$('<' + tagName + '/>')

ded avatar Nov 25 '12 18:11 ded