TiMVC icon indicating copy to clipboard operation
TiMVC copied to clipboard

Comment Error

Open frodeaux opened this issue 13 years ago • 1 comments

This is nothing major, just something I caught while looking into this framework. BTW the framework seems very useful and I plan to study it a bit more. The example is a huge help, probably better than documentation would ever be, although a bit more documentation would be nice !

Anyway, the commenting error in Resources/mvc/controllers/example.js For the this.tabgroup function the comment points to a file that doesn't exist. Like I said this is not really a big deal except when trying to learn the framework by following the example.

Another question I have: You seem to create the tab group in the example controller, since technically the tabs and tab group are part of a View, shouldn't the definition be in a view file? This is just an observation, I have much more to study on this framework, I am just wondering if you could clear this up for me !

frodeaux avatar Jun 14 '12 13:06 frodeaux

As for first question I removed that part of comment, since it is more about your second question. If you action is small you dont have to create new file/view you can put code directly to action, tabgroup illustrate that, dashboard and multidashboard works as it should. This is just an example of using controllers.

Just update and it will be fine

flakerimi avatar Jun 29 '12 12:06 flakerimi