`data:` URL validation is too narrow.

Open puellanivis opened this issue 5 years ago • 2 comments

A non-exhaustive list of URIs that fail validation can be seen here: https://play.golang.org/p/pKsNZZ00AKo

Of particular note, most of the example data: URIs given in RFC-2397 do not validate, despite being specific explicitly valid data URIs.

Jul 30 '20 11:07 puellanivis

Good catch! Looks like it is a similar issue to https://github.com/go-playground/validator/pull/548. Needs work.

Aug 03 '20 18:08 ovadiah-tech

Yeah, there was a poor regex that managed to spread pretty wide to nearly all of the validator packages. This is basically the canary test that I tend to do on every validate library that I find being used in our company. :laughing:

Aug 05 '20 12:08 puellanivis