deadlyjack
F-Droid builds are out of date
The current F-Droid version getting quite old 1.4.164 (164) - Added on 2021-10-12
Very out-of-date. @deadlyjack, are you still planning to support F-droid in the future? Planning to move away from open source?
Since ACode is the premiere (IMO) open source coding app and central to the flow of a great deal of open-source-minded developers, I'd like to ask for @IzzySoft's guidance, when he has time — as he's the font of all Android open source repo knowledge.
I can take a look (which would have been easier if I had known the package name :wink:). Seems like F-Droid is no longer able to build the app:
- disable: webpack fails
- disable: Task 'assembleRelease' not found in project ':app'.
1.4.164 was the last version with a successful build. 1.5.4 failed with the above errors, 1.5.5 was not even tried as at the tag it still identifies as 1.5.4 (i.e. version was only adjusted AFTER tagging, should have been BEFORE; so lifting the tag to the corresponding commit would trigger another build).
he's the font of all Android open source repo knowledge.
:flushed: Oops…
Do you know how to fix YAML prebuild section? There are some corrections.
prebuild:
- mkdir -p platforms
- npm install
- node ./utils/config.js p paid
- ./node_modules/.bin/webpack --progress --mode production
- cordova platform add android # change to android@9
- node ./utils/loadStyles.js
- sed -i -e '/signingConfig signingConfigs.release/d' -e '/gms/d' -e '/core-google-shortcuts/d'
platforms/android/app/build.gradle
No, sorry – I'm not a developer, and completely unfamiliar with node stuff (so for me it would rather be copy-pasting blindly). I couldn't even test that or, if it throws errors, guess what they mean and how to fix. Maybe you could open a merge request with that at fdroiddata? You would most likely know how to interpret output. Should you need help there then, a team member more familiar with node would certainly be able to help.
...Did http://github.com/deadlyjack/Acode/pull/430 remediate this?
No idea. The last tag I see here is 1.6.0, which was before that PR was merged; the corresponding build is disabled at F-Droid's end:
- versionName: 1.6.0
versionCode: 186
disable: webpack fails
commit: 0b5dd6d3b723ac4f1d2a8f591af3541d603106b1
We will learn more when the next tag was picked up. And to repeat myself: I cannot test this, I'm no developer :wink: But maybe I find someone to check, no promises though.
download and view the latest build log for version 1.6.0: https://f-droid.org/repo/com.foxdebug.acode_186.log.gz
look at the lines where there are the words ERROR.
there seems to be a problem with the file: /src/components/inputHints.js
sometimes he does not see the extension, sometimes the letter case is different.
Thank you so much for the report. I have fixed this. It was supposed to be '../inputhints' instead of '../inputHints'. It might work in the next update.
Building 05acef9 fails with: com.foxdebug.acode_196.log.gz
now there is only one error and the error is strange
2022-08-01 09:43:51,786 ERROR: Could not build app com.foxdebug.acode: Error running prebuild command for com.foxdebug.acode:1.6.0
perhaps you need to change the version from 1.6.0. to 1.6.1 and upload new corrected sources code?
There's no 1.6.1 in your code: https://github.com/deadlyjack/Acode/blob/main/platforms/android/app/src/main/AndroidManifest.xml#L2
Where are the "corrected sources code" if not here in this repo? :)
now there is only one error and the error is strange
That's not the error, that's the consequence.
Where are the "corrected sources code" if not here in this repo? :)
it seems to me that f-droid does not download the repository, it downloads the archive from the list of releases. are you sure that the entire repository is being downloaded?
I compared the contents of the files from this archive and from the repository entirely, and they are different. https://github.com/deadlyjack/Acode/archive/refs/tags/v1.6.0.zip I think it's easier to release a new version 1.6.1 for testing.
there should be a new archive that will take f-droid: https://github.com/deadlyjack/Acode/tags
F-Droid clones the repo at the right commit one wants. Eg. 05acef9d1c9d47fae25055948a2e133074ddae27
Not sure I follow, what is missing exactly? Link to the missing files?
Not sure I follow, what is missing exactly? Link to the missing files?
all files are there but differ in content in the repository and in the archive here https://github.com/deadlyjack/Acode/archive/refs/tags/v1.6.0.zip
I thought this particular archive was used to build
I've heard that github archives sometimes (not sure why) have different contents.
But no, we always use git to clone the whole repo, then checkout the needed commit.
Since ACode is the premiere (IMO) open source coding app and central to the flow of a great deal of open-source-minded developers, I'd like to ask for @IzzySoft's guidance, when he has time — as he's the font of all Android open source repo knowledge.
it's not that big of a deal, you're not going to code anything serious on your phone lol
https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11628 Finally it builds and works. I still need to patch the code but thanks to https://github.com/deadlyjack/Acode/pull/430 some patches are not needed.
Seems like it's broken again- last version 1.6.0
I thought development had ceased until just now.
@AeliusSaionji there's no release nor any tags, maybe they existed in the past so F-Droid could magically update... but they ain't now :(
Updated. https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13286 I have to take some change from https://github.com/deadlyjack/Acode/pull/659.