polling2 icon indicating copy to clipboard operation
polling2 copied to clipboard

Support for pulling out and processing the current tries value before the next increment

Open nhkhai opened this issue 5 years ago • 1 comments

Added the param tries_function that takes in an function which can be used to print out or modify the current tries value (before the next increment).

nhkhai avatar Feb 18 '21 02:02 nhkhai

hi nkkhai, thanks for the PR. I've just seen this PR. Looks interesting. I think I can understand why a tries_function would be useful. Can you add a unit test to show me why someone would want to use a tries_function? That would help justify the change as helpful and also make sure the test coverage is continued.

If you don't want to do that, that's cool. But could you please provide me an example of when this new parameter would be useful?

ddmee avatar Feb 28 '21 17:02 ddmee