dcapwell
dcapwell
FYI need the following so tests can run ``` diff --git .build/include-accord.sh .build/include-accord.sh index 0dc01bf2ba..079c96da1c 100755 --- .build/include-accord.sh +++ .build/include-accord.sh @@ -24,8 +24,8 @@ set -o nounset bin="$(cd "$(dirname "$0")"...
I wonder why go down this route when we could offer a simpler solution. yaml currently handles everything but validation/listeners, so could decorate the `Properties` with a new validation and...
For Pathogen, can this be fixed without doing a copy after cloning? For now im symlinking to make sure that I can get all the updates.
Glad someone got some usage out of them! No, I do not plan to update for Scala 3 as I stopped using Scala a long time ago
test this please
another thing to think about, we block things that are not safe in transactions but this logic isn't being applied to mutations nor these selects... so what is the plan...
> would you kindly elaborate? My PR doesn't change the signatures of the existing public API. this changes public APIs, which increases the scope of this patch. * `upgrades` is...
removed my blocking as I am out next week, so wouldn't want to block if others approve
fixed all feedback or asked for more details (also poked you in slack) you have 2 similar / related feedbacks, so trying to address here (GH isn't letting me reply...)...
ok pushed to using the new `CommandsBuilder`... the test is now ``` statefulBuilder.check(commands(this::stateGen) .preCommands(state -> state.preActions.forEach(Runnable::run)) .add(2, (rs, state) -> { EnumSet possibleTopologyChanges = possibleTopologyChanges(state); if (possibleTopologyChanges.isEmpty()) return ignoreCommand(); return...