Daniel (dB.) Doubrovkine

icon indicating a website link https://code.dblock.org icon indicating an email [email protected]

icon company @opensearch-project icon location New York, NY icon location @opensearch-project, ex-@aws, former CTO @artsy @ArtsyOpenSource, @vestris, active maintainer of @ruby-grape, hashie, @slack-ruby, @playplayio and more.

Results 3350 comments of Daniel (dB.) Doubrovkine

Add spec to test embedded documents changes in parent's history

I played with this, and it's definitely a bug. In short, when the parent is saved, `changes` doesn't include the changes from the child relation during update, however it does...

Sparse option breaks db:mongoid:create_indexes on existing collections

Bump @manxingxing @glebtv What do we want to do about this?

#slug should not default to _id.to_s

Ooooof I know for sure that Artsy relies on the fact that slugs default to ID, and aren't `nil`. This is a massive breaking change, isn't it?

#slug should not default to _id.to_s

> @dblock we should make this behavior configurable. As noted above, its inconsistent. A "never touched" new model will have slug default to ID, but once you call `clear_slug!` the...

uninitialized constant User

Do you have a `User` model in your app? Try to find the call stack of this exception?

uninitialized constant User

@SebastianSzturo Does setting `Mongoid::History.modifier_class_name = nil` work? We should document it, too and/or add support for that. Would appreciate a PR either way.

uninitialized constant User

@SebastianSzturo Try writing a spec that reproduces this and the fix should be fairly trivial to skip the modifier logic on `nil`.

uninitialized constant User

We still want this, maybe someone cares to help?

Modifier only changes when defined explicitly

I think the documentation is correct in its intentions, but the code doesn't do what it says. So lets call it a bug? Would appreciate tests + PR.

Modifier only changes when defined explicitly

Anyone wants to take a look at this?