Daniel (dB.) Doubrovkine

icon indicating a website link https://code.dblock.org icon indicating an email [email protected]

icon company @opensearch-project icon location New York, NY icon location @opensearch-project, ex-@aws, former CTO @artsy @ArtsyOpenSource, @vestris, active maintainer of @ruby-grape, hashie, @slack-ruby, @playplayio and more.

Results 3350 comments of Daniel (dB.) Doubrovkine

wrong number of arguments

@francelwebdev Did you do what I suggested in https://github.com/mongoid/mongoid-history/issues/238#issuecomment-613456001?

wrong number of arguments

This project is a safe place for you to try and figure it out @francelwebdev! Here to help. You should definitely be able to do 1-3 above. I'll do my...

Money-rails object is converted to Hash when storing the history

I think this is a bug. I would expect this to work. It would be helpful if you could write a spec for this.

Money-rails object is converted to Hash when storing the history

I want a test that reproduces the problem :) I think you described it perfectly well above, so that in code. Yes for fork/test/PR.

Money-rails object is converted to Hash when storing the history

You should PR what you have.

track_create, _update, and _delete should all be true by default

I'm down with this, it has always annoyed me that somehow creates and destroys would not be tracked by default. I wonder whether we should talk about this syntax in...

link from http to https

that site is https://github.com/mongoid/mongoid.github.io, and could use an HTTPs fix too :)

Skip track without modifier

Why wouldn't one add a presence validator that makes the modifier required instead of doing all this work? Assuming that doesn't do the job, this needs tests to be merged....

Skip track without modifier

Right, if the object is not `valid?` it won't save. That seems easier to express the same thing, no? Or what am I missing?

Skip track without modifier

All I am saying is that this logic should be expressed differently than with an `if`. You should be able to save something with no modifier and disabling validation the...