Daniel (dB.) Doubrovkine
Daniel (dB.) Doubrovkine
Needs a rebase
I generally now disable all Metrics in .rubocop.yml, but `--auto-gen-config` ignores all failures. The goal is to auto-correct all basic things, not to be annoying.
Do this: 1. Upgrade rubocop to 0.55.0 2. Run `rubocop -a ; rubocop --auto-gen-config` 3. Commit and PR separately. Generally just do (2) before pushing code and you'll be fine.
We used to. Haven't used it in production for a while, switched to ElasticSearch. But it works well for small self-contained problems.
I can reproduce this locally and it looks like a clear bug introduced in this PR. We could drop support for 3.0, but I'd like to understand what's going on....
I tried `fields['_type'].default_val.call` instead, and that passed all tests, which tells me you're missing a test here for a descendant type, that is never not `nil` in the entire test...
This is simpler and works for all versions: ```ruby return {} if descendants.none? ```
@tomasc Got a moment to wrap this up?
Looks like we missed it. Care to PR? This library needs a bit of work, hasn't been updated for a while. Maybe move from Travis-CI to GHA, and add support...
It hasn't. Do you have a good story where you think this is useful? Personally, I think the history records always wants to correspond to a single write, otherwise I...