Daniel (dB.) Doubrovkine
Daniel (dB.) Doubrovkine
Yes! Making swagger-ui a dist gem and making it a dependency is something we'd take here.
The newer swagger-ui-dist makes this easier. We should be doing something like https://github.com/artsy/doppler/pull/139. Maybe someone wants to take a stab?
> Yeah. Update task doesn't seem to work anymore > > ``` > $ bundle exec rake swagger_ui:dist:update > Cloning into /tmp/swagger-ui20190806-10968-xymd0x ... > Removing files from /home/user/apps/some_app ... >...
Would appreciate a spec, maybe even a fix, please.
I think this will need a bit of work, see how things are added to the request here: https://github.com/TinkerDev/grape-swagger-rails/blob/master/app/views/grape_swagger_rails/application/index.html.erb#L49.
I have some questions. Why would you rather do this than include the additional stylesheet in your `app/assets/stylesheets/application.css`? Assuming we still want this feature, I think we should make it...
I think as far as tests go this is good.
I think so. Supposedly once that's fixed there we can verify that this test passes.
I haven't dug in the discussion above, but I am interested in fixing anything that's broken here, please make pull requests!
I commented in #48.