Daniel (dB.) Doubrovkine

Results 3350 comments of Daniel (dB.) Doubrovkine

> Will this change make into the next release? Someone needs to rebase this PR against main and iterate it to green. Looks like @jdnvn is unfortunately MIA, care to...

This looks like a straightforward bug. Start by writing a REST test for it (https://github.com/opensearch-project/OpenSearch/blob/main/TESTING.md#testing-the-rest-layer), maybe add to https://github.com/opensearch-project/OpenSearch/blob/95fe9cbabcf9da0a5fad6eafd4092b4284520a9a/modules/mapper-extras/src/yamlRestTest/resources/rest-api-spec/test/rank_features/?

Please don't forget to add context to https://github.com/opensearch-project/opensearch-api-specification.

Let's keep in mind that while node-to-node we may not see as much benefit, client-to-server switching from JSON to protobuf should. There's also a significant improvement in developer experience if...

> Thanks a lot @finnegancarroll , it looks like we are at crossroads now: should we move forward with protobuf (since the latency wins are moderate) or (may be) move...

Please make sure to queue up an update to the OpenAPI spec in https://github.com/opensearch-project/opensearch-api-specification with this.

@amberzsy Couple of thoughts: 1. I think we want to generate these from the complete spec, not a partial namespace one, e.g. https://github.com/opensearch-project/opensearch-api-specification/releases/download/main-latest/opensearch-openapi.yaml (a release). 2. It might make sense...

> yes, technically, we definitely should have this automated and have it as part of build process. i can maybe have simple version matchAll query and related schema to unblock...

> 2\. Gaps between https://opensearch.org/docs/latest/api-reference/search/ and https://github.com/andrross/opensearch-api-specification/tree/main. The doc is incorrect/is missing information. We have https://github.com/opensearch-project/documentation-website/issues/7700 that we plan to take on soon. > a. Numeric type: number defined in...

Want to try to write a (failing) YAML REST test? https://github.com/opensearch-project/OpenSearch/blob/main/TESTING.md#testing-the-rest-layer