Daniel (dB.) Doubrovkine
Daniel (dB.) Doubrovkine
I checked off the first two boxes, but we still need all the other components to come in and add themselves to check the rest.
Manifest auto-creation is https://github.com/opensearch-project/opensearch-build/pull/729.
Does `params: API::Entities::Status.documentation` not expose those parameters with validation (Grape has extensive support for that)? And yes, validation would be definitely very useful if the above doesn’t work. When used...
@LeFnord i think the idea is that you can use entities to receive data in the same format as presented
@OuYangJinTing care to answer the q above and update CHANGELOG, please?
~How does this interact with `allow_blank`? Document the new validator in https://github.com/ruby-grape/grape?tab=readme-ov-file#built-in-validators.~ Ok, it's just an option on `length`, I understand. What happens if I `allow_blank: true` on the `length`...
I'd love some other people's opinion on whether we do want the `allow_nil` option or reuse `allow_blank` for the length validator, maybe @ericproulx?
> > @ericproulx Thank you for your detailed insights and explanations with examples.👍 > > Considering the above, in order to avoid bring too much complexity. I think the length...
> > Thanks! > > Is this a breaking change or a bug fix? If it's a breaking change, then we need to major-bump version 😱 . If it's a...
> Feels like a bug fix to me :). Nonetheless, I'm not sure about the UPGRADING comments since its a bug fix. I think better safe than sorry. Merging.