Daniel (dB.) Doubrovkine

Results 3350 comments of Daniel (dB.) Doubrovkine

> > Glad you're adding an API with specs! > > Will need working tests as part of the PR, otherwise looking ok. > > is there any other tests...

> @dblock should we add a higher version on the tests as the feature flag pr(#454) is blocked on the other fields being added to the spec first? thoughts? That...

@neetikasinghal Looks like the OpenSearch PR got merged, want to finish this and add a 2.17 to CI?

> > @neetikasinghal Looks like the OpenSearch PR got merged, want to finish this and add a 2.17 to CI? > > sure, what would be the @sha256 for 2.17?...

> @dblock there would be some more needs for the test to return a status of 200 - e.g. it needs a node with search role configured, else the API...

> Thats not a bad idea, however these features would be pulled in as well into the main code someday, so there should be an easy way to remove the...

> @dblock to unblock the specs being present in the package, can we merge this change without the tests and i can add follow-up issues to add the setup for...

@neetikasinghal want to finish this?

I personally prefer a type like `ByteSizeHuman` or `HumanByteSize` (not sure what our preference is, would look at other types) because it tells client generators to treat the type as...