Daniel (dB.) Doubrovkine

Results 3354 comments of Daniel (dB.) Doubrovkine

The `vague` option is just a fallback to the Rails/ActionView version of `distance_of_time_in_words`. Sort of a repro in https://github.com/dblock/distance_of_time_in_words/commit/d38961feb716de4310a485b10d80a9878c337c6b, if anyone wants to fix. ``` 1) A better distance_of_time_in_words with...

Looks great, let's merge it.

@VachaShah manual backport pls :(

@kkmr do examine and comment on flaky tests when you see a gradle build failure when you see it before hitting approve ;)

> ❌ Gradle check result for [0851f2e](https://github.com/opensearch-project/OpenSearch/commit/0851f2e63d8b12b60e67e781abecc1313c8b1b6c): [FAILURE](https://build.ci.opensearch.org/job/gradle-check/38048/) > > Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure [a flaky...

> ❌ Gradle check result for [0851f2e](https://github.com/opensearch-project/OpenSearch/commit/0851f2e63d8b12b60e67e781abecc1313c8b1b6c): [FAILURE](https://build.ci.opensearch.org/job/gradle-check/38104/) > > Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure [a flaky...

Looks like the backport in https://github.com/opensearch-project/OpenSearch/pull/13513 never happened, @rahulkarajgikar can you please make sure it is backported?

I like this proposal because it's effectively identical to https://github.com/opensearch-project/opensearch-sdk-java except that you are offering to refactor core vs. exposing a new interface on top of core. Generally, refactoring core...

> Which brings me to the question: do we need to write these interfaces or can we generate them from the OpenAPI spec? I think we can. It's a ton...

Thanks for keeping an open mind @fddattal! In picking similar-ish solutions in terms of complexity, risk and cost I would always take the one that's viable most long term. >...