Daniel (dB.) Doubrovkine

Results 3350 comments of Daniel (dB.) Doubrovkine

Do you have some global class `Error` somewhere? Any references to `Faraday::Error`? Any monkey patches? `Faraday::Error` is definitely a class (see https://github.com/lostisland/faraday/blob/master/lib/faraday/error.rb), so it looks like it thinks `Faraday::Error` is...

Locked down at runtime in https://github.com/slack-ruby/slack-ruby-client/pull/283

This seems a bit excessive, and will swallow all warnings, including useful ones. The failing test runs the command line CLI and checks for output, wanting to ensure that it...

@schinery I wonder whether the deprecation warnings are going to stderr and the expected output to stdout?

Generally I would like to include clear recommendation in README for this and possible default code that responds to commands into a defer-like behavior by default.

I'd really appreciate if someone could clarify all this in the README, especially for async noobs like me. I just want to know what I am supposed to do :)

I think metadata is designed to add additional detail and not be source of error. Would logging the error with complete metadata be more appropriate than throwing it into the...

I am fine with your approach btw, but I don’t think this should be optional. I don’t see why it wouldn’t become the new default. Nobody is relying or should...

I think it's a great idea @jmanian and I wouldn't worry about the number of classes. It's a definite improvement for the developer as we constantly compare `e.error` in so...