Not buildable with CMake, on some platforms?
To build under Linux x86_64, I needed to add the following line to CMake:
target_link_libraries(xlisp m)
To build under Linux aarch64 (termux):
target_link_libraries(xlisp m)
set_property(TARGET xlisp PROPERTY POSITION_INDEPENDENT_CODE ON)
As I understand it, the first is the addition of the math library, and the second is about the -fPIC option for compilation.
I don't create PR because I don't know CMake well, perhaps it should be made platform dependent?
@cousinitt , if I may ask, could you please take a look at this and comment.
My Linux machine got nuked (motherboard). I'll check it out when I'm back up and running - but thanks a bunch for the feedback!
On Wed, Jan 26, 2022 at 12:54 PM Gliese852 @.***> wrote:
To build under Linux x86_64, I needed to add the following line to CMake:
target_link_libraries(xlisp m)
To build under Linux aarch64 (termux):
target_link_libraries(xlisp m) set_property(TARGET xlisp PROPERTY POSITION_INDEPENDENT_CODE ON)
As I understand it, the first is the addition of the math library, and the second is about the -fPIC option for compilation. I don't create PR because I don't know CMake well, perhaps it should be made platform dependent? @cousinitt https://github.com/cousinitt , if I may ask, could you please take a look at this and comment.
— Reply to this email directly, view it on GitHub https://github.com/dbetz/xlisp/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKL5LYHPKIJHQLZNTWPROELUYA7PVANCNFSM5M32T7KQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>