RAiDER icon indicating copy to clipboard operation
RAiDER copied to clipboard
verified publisher icon dbekaert

fix some comments in LOS and ZREF

Open jlmaurer opened this issue 4 years ago • 5 comments

Description

  • There is a typo in the losreader.py that states heading angle is degrees CW from north, when ISCE in reality uses CCW from east. The comment has been changed to reflect this convention.
  • Also fixed the default value of zref to reflect what is actually used. This should be addressed later as zref is not currently being used in ZTD calculation

jlmaurer avatar Dec 02 '21 22:12 jlmaurer

@sssangha can you verify that the comment change I made in the losreader file is correct? I.e. that the direction is ccw from east, not cw from north.

jlmaurer avatar Jun 16 '22 02:06 jlmaurer

Pinging @sssangha on this. Thanks!

jlmaurer avatar Jun 30 '22 17:06 jlmaurer

@jlmaurer can this be closed?

dbekaert avatar Mar 16 '23 02:03 dbekaert

@dbekaert I'm still not sure which convention for heading is actually correct. The dev branch still says cw from north, but not sure if that is actually the right one. If so then yes can be closed, if not we should just update the comment.

jlmaurer avatar Mar 16 '23 02:03 jlmaurer

Can we not check isce3 documentation?

dbekaert avatar Mar 16 '23 02:03 dbekaert