pgcli icon indicating copy to clipboard operation
pgcli copied to clipboard

migrate setup.py to pyproject.toml

Open deronnax opened this issue 1 year ago • 2 comments

Description

Following PEP 621, setup.py is soft-deprecated (not truly deprecated but not the way to go anymore) and metadata in pyproject.toml is the new norm. This change should be functionally strictly equivalent.

Checklist

  • [x] I've added this contribution to the changelog.rst.
  • [x] I've added my name to the AUTHORS file (or it's already there).
  • [x] I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • [x] Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

deronnax avatar May 22 '24 12:05 deronnax

Thanks for the PR @deronnax , this has been overdue for some time. CI is not happy with the change though, do you think you could figure this out, or need help? Our CI workflow is pretty simple, so I'm surprised there's been a hiccup:

https://github.com/dbcli/pgcli/blob/main/.github/workflows/ci.yml

but perhaps we're missing something there.

j-bennet avatar May 22 '24 17:05 j-bennet

All concerns addressed. Sorry for the oversights.

deronnax avatar Jul 11 '24 11:07 deronnax

@j-bennet let's merge ?

deronnax avatar Dec 03 '24 09:12 deronnax

@deronnax Yes! thanks for the ping.

j-bennet avatar Dec 04 '24 03:12 j-bennet

Merged! Well done @deronnax and @dbaty.

j-bennet avatar Dec 04 '24 03:12 j-bennet