TiShadow icon indicating copy to clipboard operation
TiShadow copied to clipboard

Windows: failed to install TiShadow, issue with package nan

Open hannta opened this issue 9 years ago • 1 comments

I tried to install TiShadow to my Win10, got the following error:

C:\Users\user\AppData\Roaming\npm\node_modules\tishadow\node_modules\socket.io\node_modules\socket.io-client\node_modules\ws\node_modules\nan\nan.h(409): error C2039: 'ExternalAsciiStringResource': is not a member of 'v8::String' [C:\Users\user\AppData\Roaming\npm\node_modules\tishadow\node_modules\socket.io\node_modules\socket.io-client\node_modules\ws\build\bufferutil.vcxproj]
 C:\Users\user\.node-gyp\4.3.1\include\node\v8.h(2081): note: see declaration of 'v8::String'
C:\Users\user\AppData\Roaming\npm\node_modules\tishadow\node_modules\socket.io\node_modules\socket.io-client\node_modules\ws\node_modules\nan\nan.h(409): error C2065: 'ExternalAsciiStringResource': undeclared identifier [C:\Users\user\AppData\Roaming\npm\node_modules\tishadow\node_modules\socket.io\node_modules\socket.io-client\node_modules\ws\build\bufferutil.vcxproj]

TiShadow uses pretty old socket.io and socket.io-client which has issues with ws \ nan packages. More info: https://github.com/socketio/engine.io-client/issues/376 & https://github.com/socketio/socket.io/issues/2057

I managed to fix this updating ws packages as mentioned here, but I think TiShadow should update socket.io packages.

hannta avatar Apr 08 '16 12:04 hannta

@hannta, since you've done the work already, I'm happy for a PR.

dbankier avatar Apr 09 '16 22:04 dbankier