ide-powershell icon indicating copy to clipboard operation
ide-powershell copied to clipboard

Transpiler glob doesn't point to any source files

Open smhxx opened this issue 7 years ago • 0 comments

Hi there! There was a conversation on the Atom Slack yesterday in which someone linked to this package, and while browsing I noticed that the glob used in the atomTranspilers listing in package.json is a little wonky and doesn't currently match any of the .ts source files. The glob in question is:

{!(node_modules)/**/,}lib/*.ts?(x)

which could be expressed as "all .ts and .tsx files anywhere in the directory structure of the package, as long as they are not descendants of the node_modules folder, and the immediately containing folder is called lib." Since the source files are all contained in the src directory now, none of them actually fit this glob. I take partial responsibility for the confusion, since the documentation for atom-ts-transpiler doesn't actually explain what the "recommended" glob means very well or how to modify it if desired. Anyway, any of the following globs would work fine, depending on whether you'd prefer to use a catch-all or something more specific:

  • {!(node_modules)/**/,}*.ts?(x) (all .ts and .tsx files anywhere in the directory structure, as long as they are not descendants of the node_modules folder)
  • src/**/*.ts (all .ts files which are descendants of the src folder)
  • src/*.ts (all .ts files which are immediately contained in the src folder)

Just thought I'd chime in to avoid the confusion that would happen if the next release mysteriously broke and nobody knew why. Cheers! 😂

smhxx avatar Mar 29 '18 14:03 smhxx