dlib icon indicating copy to clipboard operation
dlib copied to clipboard

[question] NaN check for optimization algorithms?

Open Red-Portal opened this issue 7 years ago • 1 comments

I found out after painful debugging that dlib's find_global_min fails with a segmentation fault when the observed values contain NaN. What do you think about including a NaN checking procedure to optimization algorithms? If you like the idea I'll work on it and commit to dlib.

Red-Portal avatar Dec 28 '18 10:12 Red-Portal

It certainly shouldn't segfault. So yeah, if you want to submit a PR that makes it throw dlib::error or puts a DLIB_CASSERT on this then that would be a good addition.

davisking avatar Dec 28 '18 13:12 davisking