David Figatner comments

Results 248 comments of


                                            David Figatner

feat: wrap text, align text vertically and auto resize row

Cool. Thanks for the fixes. > When triggered the transaction is put on hold, till a callback from renderer is received having row heights. If I enable it in tests,...

feat: wrap text, align text vertically and auto resize row

We do not have a great way of running TS+rust tests. vitest supports it, but I've not been successful in getting it to run consistently. Right now, all the JS...

feat: wrap text, align text vertically and auto resize row

Please resolve conflicts (hopefully last one)

feat: wrap text, align text vertically and auto resize row

I relied on this in my PR: https://github.com/quadratichq/quadratic/pull/1526. I fixed the merge conflicts there and will close this. We'll combine the review for this one and fit-numbers together (I moved...

feat: wrap text, align text vertically and auto resize row

Ugh. Let me see if I can fix that.

fix: dispose undo-redo event listener

Thanks, this is a good change.

Bincode file implementation

Code LGTM . I can't approve since I started this PR. @ddimaria please approve.

bug: data validations don't work

This is not a data validations issue. The "6 months", etc. is being converted into a duration; the "6mo" is the display for that duration. We don't currently have a...