David Sanders
David Sanders
Here's a fun development from today. For the string literal parsing portion of our custom parser, I'm going to just defer to python's parsing facilities. Parsing string literals is pretty...
The `VyperAST.from_python_ast` method I just mentioned has one potential issue at this point. It automatically infers the proper `VyperAST` subclass to use for an instance of python's standard `ast.AST` subclasses....
@jacqueswww I think all of that is clarified in the link that @rocky posted in his gist comment: https://solidity.readthedocs.io/en/develop/miscellaneous.html#source-mappings
I haven't looked at the specific code, but I wonder if the behavior of some of those checks could be duplicated by appropriately coded try/except blocks. According to the docs,...
I've always felt weird about disabling asserts since some libraries might incorrectly use them as a general exception throwing mechanism. Thoughts on that?
@carver Actually, no thankfully. And I guess it's probably not a very big risk and we'd notice it pretty quickly if a library broke in optimized mode. But it does...
@pipermerriam Yes, I agree with that. Even if third party users of our libraries didn't use mypy, it would still give some guarantees about their internal correctness and the interactions...
I seem to recall that the choice of instance vs. class method for all of those implementations was pretty deliberate. I think the issue was that, as calls to super...
Thoughts on this @pipermerriam ?
That seems like the most natural way to do it.