htmlwithsuperpowers icon indicating copy to clipboard operation
htmlwithsuperpowers copied to clipboard

fix: Missing "this" in brewery app code

Open tinykite opened this issue 2 years ago • 2 comments

What this does

Adds a missing "this" to the examples for building a brewery app with Lit:

 ${this.breweries.map(
          brewery => html`
            <li>
              <brewery-template
                .brewery="${brewery}"
                .toggleVisitedStatus=${() => this.toggleVisitedStatus(brewery)}>
              </brewery-template>
            </li>
          `,
        )}

Without it, the example code loads but indefinitely shows "Loading" text instead of the list of Minneapolis breweries. (Which is a lovely sight, as a Minneapolis local!)

tinykite avatar Nov 03 '23 13:11 tinykite

Deploy Preview for htmlwithsuperpowers failed.

Name Link
Latest commit 13742941c24d47c239a1c598841eb12980389349
Latest deploy log https://app.netlify.com/sites/htmlwithsuperpowers/deploys/6544f73f1ba21100087c37d3

netlify[bot] avatar Nov 03 '23 13:11 netlify[bot]

Great, happy to suggest it!! Wasn't sure about the deploy issues, so would love a hand there.

tinykite avatar Nov 03 '23 14:11 tinykite