Vasilis Vryniotis
Vasilis Vryniotis
@vcarpani Sure thing. Thanks a lot for putting the time to fix this.
@vcarpani Sounds good. Feel free to ping me once you push again to speed up the reviews.
@ain-soph Thanks a lot for your contribution! Concerning the linter, if you check the [CI](https://app.circleci.com/pipelines/github/pytorch/vision/18731/workflows/38887801-2a22-478d-9528-6fdf95b89d4a/jobs/1515423?invite=true#step-104-12) on tab `Required lint modifications` it will show you what's the problem: Concerning your point...
@ain-soph Could you please share the exact command you use to train it to ensure we are not missing anything from our side?
Ooops, there are also memory issues on GPU both on [linux](https://app.circleci.com/pipelines/github/pytorch/vision/19216/workflows/631388a0-8439-4f65-b907-4b41a9370cf8/jobs/1555278) and [windows](https://app.circleci.com/pipelines/github/pytorch/vision/19216/workflows/631388a0-8439-4f65-b907-4b41a9370cf8/jobs/1555296). I know that a different test is actually failing but this can happen. Sometimes adding a bing...
@parth-shastri Thanks for the contribution. As noted at https://github.com/pytorch/vision/issues/6192#issuecomment-1164159264, we are currently reviewing the API of Transforms so ideally we don't want to introduce new ones while working on it....
@ain-soph thanks for the PR! Please comment on this ticket to be able to assign it to you. Github won't let me do it. :(
@JLrumberger thanks, this is very interesting! We definitely want to consider this after finalizing the main API of the transforms. We want to avoid making it more complex right now,...
I had a look yesterday on the PR to confirm the only changes were the addition of `-> None`. Though I am usually in favour of typing annotations on methods...
Good call @oke-aditya. Thanks for raising this. It would be great to fix this as this is a bug. The problem is it's not yet merged (ping Francisco to have...