datreeio
Ensure seccomp not unconfined rule
Added the new schema, used defs for reusability. Documentation link is still needed.
@Heydad-Helfer Thank you for the PR! Do you also plan to write the docs for this rule? https://github.com/datreeio/docs
@Heydad-Helfer Thank you for the PR! Do you also plan to write the docs for this rule? https://github.com/datreeio/docs
Hi. I can add this, but it'll take me some time. Do you want to wait on the merge until a documentation is available?
Hi, unfortunately not yet, as I didn't have much time to finish this. I'll work on it this weekend.
On Thu, Sep 8, 2022, 14:21 Eyar Zilberman @.***> wrote:
@Heydad-Helfer https://github.com/Heydad-Helfer is this ready for code review?
— Reply to this email directly, view it on GitHub https://github.com/datreeio/datree/pull/769#issuecomment-1240582281, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALBCN376DEEUNHHW5IKKJWDV5HD4LANCNFSM57Y52RKQ . You are receiving this because you were mentioned.Message ID: @.***>
@Heydad-Helfer no worries, take your time. just ping me when I should review it again :)
@Heydad-Helfer Hey Heydad, left you some comments on your PR:)
Also, we created the docs for this rule: https://github.com/datreeio/docs/pull/89
Hi. Thanks. I'll make the changes.
On Thu, Oct 6, 2022, 12:15 hadar-co @.***> wrote:
@Heydad-Helfer https://github.com/Heydad-Helfer Hey Heydad, left you some comments on your PR:)
Also, we created the docs for this rule: datreeio/docs#89 https://github.com/datreeio/docs/pull/89
— Reply to this email directly, view it on GitHub https://github.com/datreeio/datree/pull/769#issuecomment-1269651963, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALBCN3ZW2AQ3TLSDYED3NITWB2KBVANCNFSM57Y52RKQ . You are receiving this because you were mentioned.Message ID: @.***>
@Heydad-Helfer Thanks, just a couple of last things -
- I left a comment regarding some lines to add to support Deployments as well (currently the rule will only work for Pods).
- All of our rules have test files under pkg/policy/tests (1 passing manifest and 1 failing for each rule). Can you please add test files for your rule? They should be called 61-pass.yaml and 61-fail.yaml.
And that should be it! 🥳