datree icon indicating copy to clipboard operation
datree copied to clipboard

Improve test command coverage for networking use cases

Open noaabarki opened this issue 4 years ago • 8 comments

Describe the solution you'd like Add tests for networking failures flows in test command datree test <path>

Basic use cases to cover:

Failed to create evaluation

  • should create evaluation → meaning to call CreateEvaluation
  • should not request evaluation → meaning not to call Evaluate
  • should print mocked errors.

Failed to request evaluation

  • should create evaluation → meaning to call CreateEvaluation
  • should request evaluation → meaning to call Evaluate with returned evaluationID
  • should print mocked errors.

Requirements Golang basic level.

noaabarki avatar Jan 17 '22 22:01 noaabarki

I would like to work on this @noaabarki

Kanika637 avatar Feb 25 '22 04:02 Kanika637

@Kanika637, it's yours 💪🏻

noaabarki avatar Apr 07 '22 16:04 noaabarki

@Kanika637 Are you still working on this issue, or can we reassign it?😊

adifayer avatar May 23 '22 19:05 adifayer

Hey @adifay, actually I could not get hold of the issue. You can reassign it, sorry for the inconvenience.

Kanika637 avatar May 25 '22 17:05 Kanika637

Hey @noaabarki, can you send me the slack invitation, I need to troubleshoot some issues I have while installing datree, and also to discuss this GitHub issue, I want to take it up.

KiranSatyaRaj avatar Nov 22 '22 13:11 KiranSatyaRaj

Hi @KiranSatyaRaj, you got it!

This is the invite URL for Datree Slack channel: https://join.slack.com/t/datreecommunity/shared_invite/zt-1kaxe67uc-o0uO3EuK3kxjV3PSeqe~ZA.

noaabarki avatar Nov 22 '22 15:11 noaabarki

Hey @noaabarki, I didn't work with Git much and had less idea on how to deal with it, all these days I was learning Git and blogging it along the way, I'm back now and will start working on this issue, so far I got a hold of this if there's anything I'm stuck with I'll get back to you, thanks Noaa

KiranSatyaRaj avatar Nov 30 '22 10:11 KiranSatyaRaj

Hey @noaabarki Can I work on this if no one is working?

What I understand from the issue is that-

We have to add tests based on- Test case 1st- A scene where evaluation fails use the function CreateEvaluation and make it return an error

Test case 2nd- system does not proceed to request evaluation as our evaluation failed check that Evaluate function not gets called Check that test gets captured and prints expected error

Test case 3th- Creating an evaluation is successful Call Evaluate function with evaluationID

having a small doubt in which directory I need to create the test file? Like We need to have a test file in which the test scene will be there

Bharadwajshivam28 avatar Mar 03 '24 19:03 Bharadwajshivam28